Re: [PATCH 1/2] arm64: dts: qcom: sm8250: add pinctrl for SPI using GPIO as a CS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Feb 4, 2021 at 4:25 PM Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:
>
> > > > +                             mux {
> > >
> > > Rather than splitting the properties in {mux, cs, config} I think it
> > > makes more sense to split them in {spi, cs} or something like that.
> >
> > In general pinconf doesn't belong in the SoC dts file.  If there's no
> > reason to change it seems like this should match what sc7180 did.
> >
>
> Right, but I still would prefer the pinctrl state to be split by
> function/pins, rather than pinmux vs pinconf. That way it's natural to
> add pinconf properties to the various functional parts (i.e. bias or
> drive-strength for the spi pins vs cs).
>
> Do you have any concerns with this?

I read this a few times and I'm not exactly sure what you're
proposing.  Can you provide an example of what you want it to look
like in this case?

-Doug



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux