On Thu 04 Feb 14:49 CST 2021, Dmitry Baryshkov wrote:
> GENI SPI controller shows several issues if it manages the CS on its own
> (see 37dd4b777942 ("arm64: dts: qcom: sc7180: Provide pinconf for SPI to
> use GPIO for CS")) for the details. Provide pinctrl entries for SPI
> controllers using the same CS pin but in GPIO mode.
>
Doug, can you confirm that this is the final (or at least current)
verdict?
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 380 +++++++++++++++++++++++++++
> 1 file changed, 380 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 3cea28058a91..03015174ec06 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3046,6 +3046,25 @@ config {
> };
> };
>
> + qup_spi0_cs_gpio: qup-spi0-cs-gpio {
There might be others who need the same states, but I would prefer if we
move this to the device's dts.
> + mux {
Rather than splitting the properties in {mux, cs, config} I think it
makes more sense to split them in {spi, cs} or something like that.
Regards,
Bjorn
