Hello Jack, On 04-02-21, 10:05, Jack Pham wrote: > On Thu, Feb 04, 2021 at 10:39:03PM +0530, Vinod Koul wrote: > > From: Jack Pham <jackp@xxxxxxxxxxxxxx> > > + > > + resets = <&gcc 20>; > > Shouldn't this (and all the other gcc phandles below) use the > dt-bindings macros from here? > https://patchwork.kernel.org/project/linux-arm-msm/patch/20210118044321.2571775-5-vkoul@xxxxxxxxxx/ Ideally yes but it would cause build failure on qcom tree and the header is not available here. I have a patch [1] to convert all numbers to enum values which would be sent once header is in qcom tree (after next merge window).. This way we could get SM8350 booting to shell with basic things on next rc1 rather than wait for 2 cycles. Thanks -- ~Vinod
