Hi, On Monday 18 Jan 2021 at 14:54:11 (+0800), Shawn Guo wrote: > On Mon, Jan 18, 2021 at 2:43 PM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > > > On 13-01-21, 10:36, Viresh Kumar wrote: > > > On 12-01-21, 22:59, Bjorn Andersson wrote: > > > > But that said, why are the ioremap done at init and not at probe time? > > > > > > These are some hardware registers per cpufreq policy I believe, and so > > > they did it from policy init instead. > > > > > > And yes I agree that we shouldn't use devm_ from init() for the cases > > > where we need to put the resources in exit() as well. But things like > > > devm_kzalloc() are fine there. > > > > > > Ionela, since you were the first one to post a patch about this, can > > > you send a fix for this by dropping the devm_ thing altogether for the > > > ioremap thing ? Mark it suggested by Bjorn. Thanks. > > > > Ionela, I hope you are working on this so we can get it fixed quickly > > ? > > Let me take it over. I will try to send a patch out today. > I did not get any cycles for this until today. I'm happy for you Shawn to take it over if you'd like, and I'm happy to review and test. Thanks, Ionela. > Shawn
