On 12-01-21, 22:59, Bjorn Andersson wrote: > But that said, why are the ioremap done at init and not at probe time? These are some hardware registers per cpufreq policy I believe, and so they did it from policy init instead. And yes I agree that we shouldn't use devm_ from init() for the cases where we need to put the resources in exit() as well. But things like devm_kzalloc() are fine there. Ionela, since you were the first one to post a patch about this, can you send a fix for this by dropping the devm_ thing altogether for the ioremap thing ? Mark it suggested by Bjorn. Thanks. -- viresh
