On Thu, Dec 10, 2020 at 5:38 AM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Mon, 7 Dec 2020 at 19:43, Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Fri, 04 Dec 2020 05:24:01 +0300, Dmitry Baryshkov wrote: > > > Convert soc/qcom/qcom,smem.txt bindings to YAML format. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > .../bindings/soc/qcom/qcom,smem.txt | 57 --------------- > > > .../bindings/soc/qcom/qcom,smem.yaml | 73 +++++++++++++++++++ > > > 2 files changed, 73 insertions(+), 57 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt > > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smem.example.dt.yaml: memory@fc428000: 'device_type' is a required property > > From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/memory.yaml > > Rob, Bjorn, this opens a question for me: do we have to specify > device_type for the following device node? Or is it a false positive? Well, 'memory' nodes should be 'main memory' that the OS manages. This looks more like onchip SRAM, so 'sram@fc428000' perhaps. Rob
