On Mon, 7 Dec 2020 at 19:43, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Fri, 04 Dec 2020 05:24:01 +0300, Dmitry Baryshkov wrote:
> > Convert soc/qcom/qcom,smem.txt bindings to YAML format.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > .../bindings/soc/qcom/qcom,smem.txt | 57 ---------------
> > .../bindings/soc/qcom/qcom,smem.yaml | 73 +++++++++++++++++++
> > 2 files changed, 73 insertions(+), 57 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,smem.example.dt.yaml: memory@fc428000: 'device_type' is a required property
> From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/memory.yaml
Rob, Bjorn, this opens a question for me: do we have to specify
device_type for the following device node? Or is it a false positive?
/ {
soc {
#address-cells = <1>;
#size-cells = <1>;
ranges;
rpm_msg_ram: memory@fc428000 {
compatible = "qcom,rpm-msg-ram";
reg = <0xfc428000 0x4000>;
};
};
};
--
With best wishes
Dmitry
