On Thu, Nov 05, 2020 at 04:55:40PM -0800, Doug Anderson wrote: > Hi, > > On Thu, Nov 5, 2020 at 4:37 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > One important delta with respect to rev1 is a switch of the power > > supply for the onboard USB hub from 'pp3300_l7c' to 'pp3300_a' + a > > load switch. The actual regulator switch is done by the patch 'arm64: > > dts: qcom: sc7180-trogdor: Make pp3300_a the default supply for > > pp3300_hub', since it affects the entire trogdor platform. Here we > > only add the .dts files for lazor rev2 and replace the generic > > compatible entries in the rev1 .dts files. > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > --- > > > > Changes in v2: > > - patch added to the series > > > > arch/arm64/boot/dts/qcom/Makefile | 3 +++ > > .../dts/qcom/sc7180-trogdor-lazor-r1-kb.dts | 4 ++-- > > .../dts/qcom/sc7180-trogdor-lazor-r1-lte.dts | 4 ++-- > > .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 4 ++-- > > .../dts/qcom/sc7180-trogdor-lazor-r2-kb.dts | 17 +++++++++++++++++ > > .../dts/qcom/sc7180-trogdor-lazor-r2-lte.dts | 18 ++++++++++++++++++ > > .../boot/dts/qcom/sc7180-trogdor-lazor-r2.dts | 15 +++++++++++++++ > > 7 files changed, 59 insertions(+), 6 deletions(-) > > So it's pretty unlikely that this change actually happened in "-rev2". > "-rev2" was a _very_ small batch of boards that I don't think made it > into too many people's hands. You probably want "-rev3". Ah right, now that you mention it ... > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r2-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r2-kb.dts > > new file mode 100644 > > index 000000000000..7c3a702ef209 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r2-kb.dts > > @@ -0,0 +1,17 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Google Lazor board device tree source > > + * > > + * Copyright 2020 Google LLC. > > + */ > > + > > +#include "sc7180-trogdor-lazor-r1.dts" > > Should have been updated to not point to '-r1', no? ack > === > > If you want to compare, you can also look at my (abandoned) CL: > https://crrev.com/c/2481550 > > ...that forked out a "-rev3" to tag the WiFi slightly differently, but > we ended up abandoning it because we found a better way to handle the > WiFi stuff. Ok, thanks
