Quoting Jonathan Marek (2020-09-23 09:24:04) > On 9/22/20 3:04 PM, Stephen Boyd wrote: > > Quoting Jonathan Marek (2020-09-11 08:34:06) > >> Add support for the display clock controller found on SM8150 > >> based devices. This would allow display drivers to probe and > >> control their clocks. > >> > >> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx> > >> --- > >> drivers/clk/qcom/Kconfig | 9 + > >> drivers/clk/qcom/Makefile | 1 + > >> drivers/clk/qcom/dispcc-sm8150.c | 1152 ++++++++++++++++++++++++++++++ > >> 3 files changed, 1162 insertions(+) > >> create mode 100644 drivers/clk/qcom/dispcc-sm8150.c > > > > If the bindings are the same for these two drivers I wonder if there is > > anything different between the two. Maybe the two drivers can be one > > driver? > > > > Possibly, the biggest difference seems to be the plls (trion vs lucid, > different config), which could be resolved in the probe() function. If > you think combining the drivers is the right thing to do then I can do that. If that's the main difference then it sounds OK to merge the two.