Hi Doug,
On 2020-09-10 20:10, Doug Anderson wrote:
Hi,
On Thu, Sep 10, 2020 at 5:55 AM satya priya <skakit@xxxxxxxxxxxxxx>
wrote:
Remove output-high from CTS and TX as this is not really required.
During
bringup to fix transfer failures this was added to match with console
uart
settings. Probably some boot loader config was missing then. As it is
working fine now, remove it.
Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
Reviewed-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
---
Changes in V4:
- This is newly added in V4 to separate the improvements in pin
settings
and wakeup related changes.
Changes in V5:
- As per Doug's comment configured pull-down for CTS pin as earlier.
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
Looks fine to me. Slight nit that this only applies to the IDP board
but ${SUBJECT} makes it sound as if this applies to all sc7180. I
wouldn't spin just for that, though. If Bjorn agrees, he can always
adjust the subject when applying.
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Thanks for reviewing the patches, i will correct this nit in my next
version.
Thanks,
Satya Priya
