On Mon, Jul 20, 2020 at 09:48:22AM +0100, Daniel Thompson wrote: > On Sun, Jul 19, 2020 at 10:07:38AM +0200, Sam Ravnborg wrote: > > cr_bllcd can turn backlight ON or OFF. > > Fix semantitics so they equals what we know from gpio-backlight. > > brightness == 0 => backlight off > > brightness == 1 => backlight on > > > > Use the backlight_get_brightness() helper to simplify the code. > > > > v2: > > - reworked to introduce gpio-backlight semantics (Daniel) > > Wasn't this added for v5? However, I spotted this change amoung the > other patches so no worries... I do not increment version for individual patches unless there are changes. So this is the second version of this patch, but included in the v5 submission. But I can see how this can confuse the receiver. I will consider to adapt to the practice to indicate version of submission and not the individual patches. > > > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > > Cc: Jingoo Han <jingoohan1@xxxxxxxxx> > > Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> Very much appreciated - thanks! Sam
