Re: [PATCH] pinctrl: qcom: Handle broken PDC dual edge case on sc7180

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Douglas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pinctrl/devel]
[also build test WARNING on v5.8-rc4 next-20200708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/pinctrl-qcom-Handle-broken-PDC-dual-edge-case-on-sc7180/20200709-051816
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/qcom/pinctrl-msm.c:914:6: warning: no previous prototype for 'msm_gpio_handle_dual_edge_parent_irq' [-Wmissing-prototypes]
     914 | void msm_gpio_handle_dual_edge_parent_irq(struct irq_desc *desc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/msm_gpio_handle_dual_edge_parent_irq +914 drivers/pinctrl/qcom/pinctrl-msm.c

   913	
 > 914	void msm_gpio_handle_dual_edge_parent_irq(struct irq_desc *desc)
   915	{
   916		struct irq_data	*d = &desc->irq_data;
   917	
   918		/* Make sure we're primed for the next edge */
   919		msm_gpio_update_dual_edge_parent(d);
   920	
   921		/* Pass on to the normal interrupt handler */
   922		handle_fasteoi_irq(desc);
   923	}
   924	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux