Hi, On Tue, 30 Jun 2020 at 08:06, Amit Kucheria <amit.kucheria@xxxxxxxxxxxxx> wrote: > On Mon, Jun 22, 2020 at 1:06 AM Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > Port thermal zones definitions from msm-4.19 tree. Enable and add > > channel configuration to PMIC's ADC-TM definitions. Declare thermal > > zones and respective trip points. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 237 ++++++++++++++++++++++++ > > 1 file changed, 237 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts > > IMO, this should be separated in the pmic dts file like we do for > other QC platforms since the PMICs tend to be used in multiple > platforms. Unlike other PMIC/tsens thermal zones, these definitions are quite specific to the board from my point of view. > > index aa37eb112d85..78f0cf582a9a 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts > > +++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts > > @@ -24,6 +24,104 @@ chosen { > > stdout-path = "serial0:115200n8"; > > }; > > > > + thermal-zones { > > + xo-therm { > > + polling-delay-passive = <0>; > > + polling-delay = <0>; > > + thermal-sensors = <&pm8150_adc_tm 0>; > > + trips { > > + active-config0 { > > + temperature = <125000>; > > + hysteresis = <1000>; > > + type = "passive"; > > + }; > > + }; > > + }; > > + -- With best wishes Dmitry