Hi Stanimir, On Sat, May 09, 2020 at 04:21:20PM +0300, Stanimir Varbanov wrote: ... > > @@ -839,6 +849,12 @@ static int qcom_iommu_device_probe(struct platform_device *pdev) > > return PTR_ERR(qcom_iommu->bus_clk); > > } > > > > + qcom_iommu->tlb_clk = devm_clk_get(dev, "tlb"); > > IMO, devm_clk_get_optional() would be better. Yes, indeed. The function will make it clear that the clock is an optional one. I will make the change in v2. Thanks for the comment! Shawn
