Hi, On Tue, Mar 31, 2020 at 6:21 AM Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote: > > @@ -243,6 +279,14 @@ static irqreturn_t tcs_tx_done(int irq, void *p) > } > > trace_rpmh_tx_done(drv, i, req, err); > + > + /* > + * If wake tcs was re-purposed for sending active > + * votes, clear AMC trigger & enable modes and > + * disable interrupt for this TCS > + */ > + if (!drv->tcs[ACTIVE_TCS].num_tcs) > + __tcs_set_trigger(drv, i, false); Still seems weird that we have to do the untrigger in the IRQ routine here and also weird that we _don't_ do it in the IRQ routine for non-borrowed TCSes. I guess it's not the end of the world, though. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>