On 2020-03-24 10:08 am, Joerg Roedel wrote:
Hey Robin,
On Mon, Mar 23, 2020 at 04:02:33PM +0000, Robin Murphy wrote:
Yikes, this ends up pretty ugly, and I'd prefer not have this much
complexity hidden in macros that were intended just to be convenient
shorthand. Would you mind pulling in the patch below as a precursor?
Sure thing, but your mail-client seemed to have fiddled with the patch
so that is is unusable to me. I tried to fix it up, but it still doesn't
apply. Can you please re-send it to me either via git-send-email or just
as a mime-attachement?
Oops, sorry - as you might imagine I'm not in my normal workflow :)
Let me rebase that onto something actually in your tree (rather than
whatever detached HEAD this is checked out out on my laptop...) and try
resending it properly.
Other than that, the rest of the series looks OK at a glance. We should also
move fwspec->ops to dev_iommu, as those are "IOMMU API" data rather than
"firmware" data, but let's consider that separately as this series is
already long enough.
Yes, moving ops out of fwspec is next on the list, and moving the
iommu_group pointer into dev_iommu.
Cool, let me know if you need a hand with all the *_iommu_configure()
stuff - I still have plans for overhauling that lot anyway, but not
imminently, so it probably is worthwhile to do the straightforward
housekeeping first.
Thanks,
Robin.
