Hey Robin, On Mon, Mar 23, 2020 at 04:02:33PM +0000, Robin Murphy wrote: > Yikes, this ends up pretty ugly, and I'd prefer not have this much > complexity hidden in macros that were intended just to be convenient > shorthand. Would you mind pulling in the patch below as a precursor? Sure thing, but your mail-client seemed to have fiddled with the patch so that is is unusable to me. I tried to fix it up, but it still doesn't apply. Can you please re-send it to me either via git-send-email or just as a mime-attachement? > Other than that, the rest of the series looks OK at a glance. We should also > move fwspec->ops to dev_iommu, as those are "IOMMU API" data rather than > "firmware" data, but let's consider that separately as this series is > already long enough. Yes, moving ops out of fwspec is next on the list, and moving the iommu_group pointer into dev_iommu. Regards, Joerg
