Hi Matthias,
On 3/13/2020 10:12 PM, Matthias Kaehlcke wrote:
Hi Akash,
On Fri, Mar 13, 2020 at 06:42:08PM +0530, Akash Asthana wrote:
Add necessary macros and structure variables to support ICC BW
voting from individual SE drivers.
Signed-off-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
---
Changes in V2:
- As per Bjorn's comment dropped enums for ICC paths, given the three
paths individual members
include/linux/qcom-geni-se.h | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h
index dd46494..eaae16e 100644
--- a/include/linux/qcom-geni-se.h
+++ b/include/linux/qcom-geni-se.h
@@ -6,6 +6,8 @@
#ifndef _LINUX_QCOM_GENI_SE
#define _LINUX_QCOM_GENI_SE
+#include <linux/interconnect.h>
+
/* Transfer mode supported by GENI Serial Engines */
enum geni_se_xfer_mode {
GENI_SE_INVALID,
@@ -33,6 +35,15 @@ struct clk;
* @clk: Handle to the core serial engine clock
* @num_clk_levels: Number of valid clock levels in clk_perf_tbl
* @clk_perf_tbl: Table of clock frequency input to serial engine clock
+ * @icc_path_geni_to_core: ICC path handle for geni to core
+ * @icc_path_cpu_to_geni: ICC path handle for cpu to geni
+ * @icc_path_geni_to_ddr: ICC path handle for geni to ddr
+ * @avg_bw_core: Average bus bandwidth value for QUP core 2x clock
+ * @peak_bw_core: Peak bus bandwidth value for QUP core 2x clock
+ * @avg_bw_cpu: Average bus bandwidth value for CPU
+ * @peak_bw_cpu: Peak bus bandwidth value for CPU
+ * @avg_bw_ddr: Average bus bandwidth value for DDR
+ * @peak_bw_ddr: Peak bus bandwidth value for DDR
*/
struct geni_se {
void __iomem *base;
@@ -41,6 +52,15 @@ struct geni_se {
struct clk *clk;
unsigned int num_clk_levels;
unsigned long *clk_perf_tbl;
+ struct icc_path *icc_path_geni_to_core;
+ struct icc_path *icc_path_cpu_to_geni;
+ struct icc_path *icc_path_geni_to_ddr;
+ unsigned int avg_bw_core;
+ unsigned int peak_bw_core;
+ unsigned int avg_bw_cpu;
+ unsigned int peak_bw_cpu;
+ unsigned int avg_bw_ddr;
+ unsigned int peak_bw_ddr;
Those are a lot of new individual struct members. How about clustering
them, e.g.:
struct geni_icc_path {
struct icc_path *path;
unsigned int avg_bw;
unsigned int peak_bw;
};
I guess it would be better to add this structure ICC driver as you
suggested@https://patchwork.kernel.org/patch/11436905/.
struct geni_iccs_paths {
struct geni_icc_path to_core;
struct geni_icc_path from_cpu;
struct geni_icc_path to_ddr;
};
And 'struct geni_se' just gets this entry:
struct geni_icc_paths icc;
or alternatively three 'struct geni_icc_path' entries.
ok
Thanks for reviewing.
Regards
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
