Re: [PATCH V2 6/8] spi: spi-geni-qcom: Add interconnect support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/13/2020 6:46 PM, Mark Brown wrote:
On Fri, Mar 13, 2020 at 06:42:12PM +0530, Akash Asthana wrote:

+	se->avg_bw_cpu = Bps_to_icc(mas->cur_speed_hz);
+	se->peak_bw_cpu = Bps_to_icc(2 * mas->cur_speed_hz);
As I commented on the previous version to no reply there seem to be a
lot of cases where the peak bandwidth is just set to double the normal
bandwidth without obvious analysis.  Should this default be centralized?

Hi Mark,

I misunderstood previous comment on V1 patch@https://patchwork.kernel.org/patch/11386479/ as a suggestion to mention comment for peak BW choice if nothing mentioned explicitly (in this case I mentioned assume peak BW twice as average).

I understand in any case I should have ack'ed the comment atleast by replying "ok". I am sorry about it.


We are taking care of actual throughput requirement in avg_bw vote and the intention of putting peak as twice of avg is to ensure that if high speed peripherals(ex:USB) removes their votes, we shouldn't see any latency issue because of other ICC client who don't vote for their BW requirement or *actual* BW requirement. Factor of 2 is chosen randomly. Please correct/improve me if this is not okay.

If this is okay, I will centralize this design for SPI QUP, I2C and UART driver.

Regards,

Akash



--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux