On Wed, Feb 26, 2020 at 5:17 AM Sharat Masetty <smasetty@xxxxxxxxxxxxxx> wrote: > > > On 2/21/2020 2:05 AM, Rob Herring wrote: > > On Thu, 20 Feb 2020 13:42:22 +0530, Sharat Masetty wrote: > >> This patch adds a clock definition needed for powering on the GPU TBUs > >> and the GPU TCU. > >> > >> Signed-off-by: Sharat Masetty <smasetty@xxxxxxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too short > > > > See https://patchwork.ozlabs.org/patch/1241297 > > Please check and re-submit. > Hi Rob, These issues seem to be from the original code and not related > to my patch. Are these going to be blocking errors? There are no errors in this binding in mainline. You've added a 3rd clock when all the existing users have exactly 2 clocks. Rob
