On Tue, Feb 25, 2020 at 6:31 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Rob Herring (2020-02-25 05:58:19) > > On Mon, Feb 24, 2020 at 11:49 PM Taniya Das <tdas@xxxxxxxxxxxxxx> wrote: > > > > > > Hi Rob, > > > > > > On 2/25/2020 12:12 AM, Rob Herring wrote: > > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > > > > Error: Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dts:21.26-27 syntax error > > > > FATAL ERROR: Unable to parse input tree > > > > scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml' failed > > > > make[1]: *** [Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml] Error 1 > > > > Makefile:1263: recipe for target 'dt_binding_check' failed > > > > make: *** [dt_binding_check] Error 2 > > > > > > > > See https://patchwork.ozlabs.org/patch/1242999 > > > > Please check and re-submit. > > > > > > > > > > The error shows syntax error at line 21, below is the example.dts from > > > my tree and would compile for me as I have the dependency of the include > > > file when I compile. > > > > The header should be part of this patch if possible. > > > > Are patches tested in isolation instead of in series? I see this define > in the first patch in this series so it seems like automated checkers > should be able to apply the patches in series and see if they still > work, unless that is broken somehow. The series should be applied, but it's all very fragile. It's going to stay that way until someone else writes and maintains the applying patches to git logic. In any case, the header is part of the binding (being an ABI) not the driver, so it belongs in the binding patch. However, in this case, the problem was pointed out in v4 to be a typo in GCC_MSS_MFAB_AXIS_CLK. Rob
