On 13/01/2020 09:40, Vinod Koul wrote: > This series add support for Renesas USB controllers uPD720201 and uPD720202. > These require firmware to be loaded and in case devices have ROM those can > also be programmed if empty. If ROM is programmed, it runs from ROM as well. > > This includes two patches from Christian which supported these controllers > w/o ROM and later my patches for ROM support and multiple firmware versions, > debugfs hook for rom erase and export of xhci-pci functions. > I tested this on an AVM FRITZ!Box 3490, backported to 4.19: Firmware upload works fine. However, I'm seeing read errors afterwards which, I suppose, are a different story. Here is the log: [ 498.115808] ifx_pcie_bios_map_irq port 0 dev 0000:01:00.0 slot 0 pin 1 [ 498.121154] ifx_pcie_bios_map_irq dev 0000:01:00.0 irq 144 assigned [ 498.488541] renesas xhci 0000:01:00.0: xHCI Host Controller [ 498.492820] renesas xhci 0000:01:00.0: new USB bus registered, assigned bus number 1 [ 498.506123] renesas xhci 0000:01:00.0: hcc params 0x014051cf hci version 0x100 quirks 0x0000000101000090 [ 498.516869] hub 1-0:1.0: USB hub found [ 498.519631] hub 1-0:1.0: 2 ports detected [ 498.525641] renesas xhci 0000:01:00.0: xHCI Host Controller [ 498.530217] renesas xhci 0000:01:00.0: new USB bus registered, assigned bus number 2 [ 498.537846] renesas xhci 0000:01:00.0: Host supports USB 3.0 SuperSpeed [ 498.545095] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM. [ 498.554921] hub 2-0:1.0: USB hub found [ 498.557588] hub 2-0:1.0: 2 ports detected [ 523.013361] usb 1-1: new full-speed USB device number 2 using renesas xhci [ 523.182725] usb 1-1: no configurations [ 523.185085] usb 1-1: can't read configurations, error -22 [ 523.317423] usb 1-1: new full-speed USB device number 3 using renesas xhci [ 523.493710] usb 1-1: no configurations [ 523.496069] usb 1-1: can't read configurations, error -22 [ 523.501951] usb usb1-port1: attempt power cycle Regards and thanks for the patch, Andreas
