On 10/28/2019 8:30 PM, Stephen Boyd wrote:
Quoting Akash Asthana (2019-10-17 04:10:10)
On 10/16/2019 1:40 AM, Stephen Boyd wrote:
Why can't we make this driver use runtime PM?
Currently there are no plans to use runtime PM as we are interested in
enabling wakeup irq as part of system suspend only.
Does the wakeup irq code require runtime PM? I thought that any wake irq
attached to a device is armed during system wide suspend and disabled on
resume. See device_wakeup_arm_wake_irqs() called from
dpm_suspend_noirq().
So why can't we use the common code that manages wakeup irqs for
devices?
After reading about device_wakeup_arm_wake_irqs() and
dpm_suspend_noirq() APIs it's clear to me
that we don't require runtime PM feature. We have now aligned our driver
to use common code that manages
wakeup irqs for devices.
Thanks for suggesting this changes!
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project