On Sun 20 Oct 08:07 PDT 2019, kholk11@xxxxxxxxx wrote:
> From: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx>
>
> Add the SPMI regulator node in the PM8004 LSID5 (as there is where
> it resides basically 99% of the times) and set the nodes to be
> disabled by default, as not all boards have both or one of the
> lsids specified in this generic pm8004 DT.
>
> While at it, also add nice phandles to the lsids specified in this
> DT, so that we can modify their configuration or add nodes to them
> from other DTs in a nicer and more human readable fashion.
>
Shouldn't all blocks of pm8004 be declared in this file?
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/pm8004.dtsi | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8004.dtsi b/arch/arm64/boot/dts/qcom/pm8004.dtsi
> index 297b57bfa87a..0abd1abe12fc 100644
> --- a/arch/arm64/boot/dts/qcom/pm8004.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8004.dtsi
> @@ -4,17 +4,23 @@
>
> &spmi_bus {
>
> - pmic@4 {
> + pm8004_lsid4: pmic@4 {
> compatible = "qcom,pm8004", "qcom,spmi-pmic";
> reg = <0x4 SPMI_USID>;
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "disabled";
I think you should just leave this enabled, boards that doesn't have a
pm8004 should be able to omit the include of this file.
> };
>
> - pmic@5 {
> + pm8004_lsid5: pmic@5 {
> compatible = "qcom,pm8004", "qcom,spmi-pmic";
> reg = <0x5 SPMI_USID>;
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "disabled";
> +
> + pm8004_spmi_regulators: regulators {
> + compatible = "qcom,pm8004-regulators";
> + };
Looks good.
Regards,
bjorn
> };
> };
> --
> 2.21.0
>
