Quoting Geert Uytterhoeven (2019-09-27 12:10:13) > On Fri, Sep 27, 2019 at 8:26 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > Quoting Geert Uytterhoeven (2019-09-26 06:07:13) > > > On Fri, Sep 20, 2019 at 11:06 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > > Quoting Arnd Bergmann (2019-09-20 12:27:50) > > > > > On Fri, Sep 20, 2019 at 6:45 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > > > > > --- a/drivers/leds/leds-pca9532.c > > > > +++ b/drivers/leds/leds-pca9532.c > > > > @@ -472,7 +472,7 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np) > > > > int i = 0; > > > > const char *state; > > > > > > > > - match = of_match_device(of_pca9532_leds_match, dev); > > > > + match = of_match_device(of_match_ptr(of_pca9532_leds_match), dev); > > > > if (!match) > > > > return ERR_PTR(-ENODEV); > > > > > > Please convert to of_device_get_match_data() instead of adding > > > of_match_ptr() invocations... > > > > How is this workable? I left it as of_match_device() because the value > > returned may be 0 for the enum and that looks the same as NULL. > > This function is used for the DT case only, so there will always be a match. > Hence you can do devid = (int)(uintptr_t)of_device_get_match_data(dev). > Ok. Let me send out a pile of patches.
