On Fri, Sep 20, 2019 at 6:45 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > @@ -54,11 +60,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) > > void __iomem *base; > > unsigned long i; > > int ret; > > - const struct of_device_id apcs_clk_match_table[] = { > > Does marking it static here work too? It would be nice to limit the > scope of this variable to this function instead of making it a global. > Also, it might be slightly smaller code size if that works. No, I just tried and the warning returned. Arnd