On Tue, Sep 17, 2019 at 05:28:47PM +0200, Markus Elfring wrote: > > The semantic patch that makes this report is available > > in scripts/coccinelle/api/platform_get_irq.cocci. > > > > Found using - http://coccinelle.lip6.fr/ > > Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci” > be more helpful than the other description variant? Okay, will update the changelog. > > if (qup->irq < 0) { > > - dev_err(qup->dev, "No IRQ defined\n"); > > return qup->irq; > > } > How do you think about to omit the curly brackets here after only a single > statement would be used in the if branch? Completely missed that! I will update and resend. -Saiyam
