> The semantic patch that makes this report is available > in scripts/coccinelle/api/platform_get_irq.cocci. > > Found using - http://coccinelle.lip6.fr/ Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci” be more helpful than the other description variant? > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -1767,7 +1767,6 @@ static int qup_i2c_probe(struct platform_device *pdev) > > qup->irq = platform_get_irq(pdev, 0); > if (qup->irq < 0) { > - dev_err(qup->dev, "No IRQ defined\n"); > return qup->irq; > } How do you think about to omit the curly brackets here after only a single statement would be used in the if branch? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=ad062195731bea1624ce7160e79e0fcdaa25c1b5#n175 Regards, Markus
