On 16-06-19, 21:26, Bjorn Andersson wrote: > On Wed 12 Jun 02:17 PDT 2019, Vinod Koul wrote: > > > MODULE_ALIAS was missing for this driver which can be built as a > > module, so add the MODULE_ALIAS. > > > > MODULE_ALIAS() serves the purpose of providing an module alias for the > driver, which allows the automatic kernel module loader to insmod the > driver as a device needing it is being registered. > > When the device is instantiated through the OF code path the compatible > will be matched against the MODULE_DEVICE_TABLE(of, ) and if the device > is programmatically registered (through platform_device_register_*()) > then the alias "platform:XYZ" will be used. Thanks for the explanation Bjorn :) > > So, unless we're going to support module autoloading of this driver from > a board file no alias should be needed. Nope we dont, so will drop this one and as well as from SM8150 driver -- ~Vinod