On 12/06/2019 21:13, Bjorn Andersson wrote:
> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
>
>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
>> we're building MSM_GCC_8916.
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>
>
> Not sure why these are default at all.
>
> But both drivers are used on platforms other than 8916 as well, so if
> anything a fix would be to rename the APCS_MSM8916 to something more
> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
> updated and the APCS mailbox driver as well...
Used on platforms other than 8916? do you see that?
$ git grep compatible drivers/clk/qcom/a53-pll.c
{ .compatible = "qcom,msm8916-a53pll" },
$ git grep qcom,msm8916-a53pll arch/arm64/boot/dts
arch/arm64/boot/dts/qcom/msm8916.dtsi: compatible = "qcom,msm8916-a53pll";
drivers/clk/qcom/apcs-msm8916.c doesn't seem to support DT...
$ git grep qcom-apcs-msm8916-clk
drivers/clk/qcom/apcs-msm8916.c: .name = "qcom-apcs-msm8916-clk",
drivers/mailbox/qcom-apcs-ipc-mailbox.c: "qcom-apcs-msm8916-clk",
if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
apcs->clk = platform_device_register_data(&pdev->dev, "qcom-apcs-msm8916-clk", -1, NULL, 0);
$ git grep qcom,msm8916-apcs-kpss-global
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt: "qcom,msm8916-apcs-kpss-global",
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt: compatible = "qcom,msm8916-apcs-kpss-global";
arch/arm64/boot/dts/qcom/msm8916.dtsi: compatible = "qcom,msm8916-apcs-kpss-global", "syscon";
drivers/mailbox/qcom-apcs-ipc-mailbox.c: if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
drivers/mailbox/qcom-apcs-ipc-mailbox.c: { .compatible = "qcom,msm8916-apcs-kpss-global", .data = (void *)8 },
Are you sure about other platforms?
Regards.
