Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:

> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
> we're building MSM_GCC_8916.
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>

Not sure why these are default at all.

But both drivers are used on platforms other than 8916 as well, so if
anything a fix would be to rename the APCS_MSM8916 to something more
generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
updated and the APCS mailbox driver as well...

Regards,
Bjorn

> ---
>  drivers/clk/qcom/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..d5b065f64afc 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,7 @@ if COMMON_CLK_QCOM
>  
>  config QCOM_A53PLL
>  	tristate "MSM8916 A53 PLL"
> -	default ARCH_QCOM
> +	default MSM_GCC_8916
>  	help
>  	  Support for the A53 PLL on MSM8916 devices. It provides
>  	  the CPU with frequencies above 1GHz.
> @@ -31,7 +31,7 @@ config QCOM_A53PLL
>  config QCOM_CLK_APCS_MSM8916
>  	tristate "MSM8916 APCS Clock Controller"
>  	depends on QCOM_APCS_IPC || COMPILE_TEST
> -	default ARCH_QCOM
> +	default MSM_GCC_8916
>  	help
>  	  Support for the APCS Clock Controller on msm8916 devices. The
>  	  APCS is managing the mux and divider which feeds the CPUs.
> -- 
> 2.17.1



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux