On 12/06/2019 21:49, Stephen Boyd wrote: > Quoting Bjorn Andersson (2019-06-12 12:13:47) > >> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote: >> >>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when >>> we're building MSM_GCC_8916. >>> >>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx> >> >> Not sure why these are default at all. >> >> But both drivers are used on platforms other than 8916 as well, so if >> anything a fix would be to rename the APCS_MSM8916 to something more >> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be >> updated and the APCS mailbox driver as well... > > I don't see any use in being this specific. I'd prefer we just leave > this at the ARCH_FOO config level and not try anything more fancy. As Bjorn pointed out, why do these default "on" at all? https://elixir.bootlin.com/linux/latest/source/drivers/clk/qcom/Kconfig There are dozens of config knobs in drivers/clk/qcom/Kconfig and only these two force the default. Let's remove the default altogether. Regards.
