Re: [PATCH v1 2/3] drm/msm: Print all 64 bits of the faulting IOMMU address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2019 20:02, Jordan Crouse wrote:

> When we move to 64 bit addressing for a5xx and a6xx targets we will start
> seeing pagefaults at larger addresses so format them appropriately in the
> log message for easier debugging.
> 
> Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx>
> ---
> 
>  drivers/gpu/drm/msm/msm_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c
> index 12bb54c..1926329 100644
> --- a/drivers/gpu/drm/msm/msm_iommu.c
> +++ b/drivers/gpu/drm/msm/msm_iommu.c
> @@ -30,7 +30,7 @@ static int msm_fault_handler(struct iommu_domain *domain, struct device *dev,
>  	struct msm_iommu *iommu = arg;
>  	if (iommu->base.handler)
>  		return iommu->base.handler(iommu->base.arg, iova, flags);
> -	pr_warn_ratelimited("*** fault: iova=%08lx, flags=%d\n", iova, flags);
> +	pr_warn_ratelimited("*** fault: iova=%16lx, flags=%d\n", iova, flags);

Why no leading 0 for 64-bit numbers?

Will 32-bit platforms always get 8 useless characters?

Regards.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux