On 11/04/2019 11:09, Stanimir Varbanov wrote: > On 4/11/19 11:44 AM, Marc Gonzalez wrote: > >> Since we just want to map 0x100, we don't need an iommu-map-mask. > > Do you see warnings during boot about missing property? Absent iommu-map-mask property is expected. No warning: https://elixir.bootlin.com/linux/latest/source/drivers/of/base.c#L2245 /* The default is to select all bits. */ map_mask = 0xffffffff; /* * Can be overridden by "{iommu,msi}-map-mask" property. * If of_property_read_u32() fails, the default is used. */ if (map_mask_name) of_property_read_u32(np, map_mask_name, &map_mask); >>>> + /* PCIe Fundamental Reset */ >>> >>> this comment is useless :) please drop it >> >> IMO, "perst" is a poor name. Can you guess what it stands for? > > The name is got from PCIE base specification. See 6.6.1. > Conventional Reset from "PCI EXPRESS BASE SPECIFICATION, REV. 3.0" Indeed... Well, "perst" still sucks :-p Regards.
