On 10/04/2019 17:32, Stanimir Varbanov wrote: > Few comments inline. I'll send v3. Changes: - Move all X-names props *after* corresponding X(s) prop - Drop comments >> + iommu-map = <0x100 &anoc1_smmu 0x1480 1>; > > iommu-map-mask? It is optional but I had to ask :) The only RID in the system is 0x100. # lspci 00:00.0 PCI bridge: Qualcomm Device 0105 01:00.0 Ethernet controller: Qualcomm Atheros AR8151 v2.0 Gigabit Ethernet (rev c0) Since we just want to map 0x100, we don't need an iommu-map-mask. >> + /* PCIe Fundamental Reset */ > > this comment is useless :) please drop it IMO, "perst" is a poor name. Can you guess what it stands for? Regards.
