Quoting Jeffrey Hugo (2019-01-30 08:36:24) > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 7136ab1..5673a65 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -814,6 +814,21 @@ > status = "disabled"; > }; > > + mmcc: clock-controller@c8c0000 { > + compatible = "qcom,mmcc-msm8998"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + reg = <0x0c8c0000 0x40000>; > + > + clock-names = > + "xo", Weird newline here. Please put "xo" on the same line as clock-names. > + "gpll0"; > + clocks = > + <&rpmcc RPM_SMD_XO_CLK_SRC>, > + <&gcc GPLL0_OUT_MAIN>; Ah ok, so only the multimedia clks get the xo clk from rpm for now?