On 1/23/19 3:16 AM, Viresh Kumar wrote:
On 22-01-19, 16:05, Rajendra Nayak wrote:
Seeing this now during remove
[ 34.008216] ------------[ cut here ]------------
[ 34.012894] Device 'mss' does not have a release() function, it is broken and must be fixed. See Docum.
[ 34.024143] WARNING: CPU: 6 PID: 1600 at drivers/base/core.c:922 device_release+0x84/0x98
[ 34.032379] Modules linked in:
[ 34.035477] CPU: 6 PID: 1600 Comm: sh Not tainted 5.0.0-rc1-00012-g0513915837c5-dirty #34
[ 34.043724] Hardware name: Qualcomm Technologies, Inc. SDM845 MTP (DT)
[ 34.050305] pstate: 60400005 (nZCv daif +PAN -UAO)
[ 34.055141] pc : device_release+0x84/0x98
[ 34.059186] lr : device_release+0x84/0x98
[ 34.063229] sp : ffff0000183c3b40
[ 34.066574] x29: ffff0000183c3b40 x28: ffff800174b55100
[ 34.071930] x27: 0000000000000000 x26: 0000000000000000
[ 34.077285] x25: 0000000056000000 x24: 0000000000000015
[ 34.082640] x23: dead000000000100 x22: dead000000000200
[ 34.087997] x21: 0000000000000000 x20: ffff0000112f9780
[ 34.093352] x19: ffff0000112f9770 x18: ffff0000111dd6c8
[ 34.098719] x17: 0000000000000000 x16: 0000000000000000
[ 34.104072] x15: ffff0000983c3867 x14: 6966206562207473
[ 34.109438] x13: 756d20646e61206e x12: 656b6f7262207369
[ 34.114791] x11: 207469202c6e6f69 x10: 74636e7566202928
[ 34.120147] x9 : 657361656c657220 x8 : 742e7463656a626f
[ 34.125514] x7 : 6b2f6e6f69746174 x6 : 0000000000000149
[ 34.130867] x5 : 0000000000000020 x4 : 000000000001c200
[ 34.136223] x3 : 00000000ffffffff x2 : ffff0000111f5828
[ 34.141579] x1 : bc1d8ed5415ab200 x0 : 0000000000000000
[ 34.146936] Call trace:
[ 34.149413] device_release+0x84/0x98
[ 34.153116] kobject_put+0x98/0xe8
[ 34.156551] put_device+0x14/0x28
[ 34.159899] genpd_remove+0x108/0x190
[ 34.163598] of_genpd_remove_last+0xbc/0xf0
[ 34.167828] rpmhpd_remove+0x2c/0x48
[ 34.171436] platform_drv_remove+0x24/0x68
[ 34.175574] device_release_driver_internal+0x184/0x218
[ 34.180845] device_release_driver+0x14/0x20
[ 34.185152] unbind_store+0xec/0x138
[ 34.188760] drv_attr_store+0x20/0x30
[ 34.192465] sysfs_kf_write+0x48/0x58
[ 34.196163] kernfs_fop_write+0xcc/0x1c8
[ 34.200129] __vfs_write+0x34/0x170
[ 34.203654] vfs_write+0xa8/0x1b8
[ 34.206998] ksys_write+0x5c/0xc8
[ 34.210345] __arm64_sys_write+0x14/0x20
[ 34.214318] el0_svc_common+0xb4/0x118
[ 34.218107] el0_svc_handler+0x2c/0x80
[ 34.221899] el0_svc+0x8/0xc
[ 34.224804] ---[ end trace 9cee1458d0b6c175 ]---
[ 34.229490] ------------[ cut here ]------------
This shall fix it:
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 500de1dee967..8a44b1f356d0 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1711,6 +1711,15 @@ static void genpd_lock_init(struct generic_pm_domain *genpd)
}
}
+static void genpd_device_release(struct device *dev)
+{
+}
+
See Documentation/kobject.txt.
"One important point cannot be overstated: every kobject must have a
release() method, and the kobject must persist (in a consistent state)
until that method is called. If these constraints are not met, the code is
flawed. Note that the kernel will warn you if you forget to provide a
release() method. Do not try to get rid of this warning by providing an
"empty" release function.
If all your cleanup function needs to do is call kfree(), then you must
create a wrapper function which uses container_of() to upcast to the correct
type (as shown in the example above) and then calls kfree() on the overall
structure."
Guenter
+struct device_type genpd_device_type = {
+ .name = "genpd_device",
+ .release = genpd_device_release,
+};
+
/**
* pm_genpd_init - Initialize a generic I/O PM domain object.
* @genpd: PM domain object to initialize.
@@ -1770,6 +1779,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
pr_warn("%s : no governor for states\n", genpd->name);
}
+ genpd->dev.type = &genpd_device_type;
device_initialize(&genpd->dev);
dev_set_name(&genpd->dev, "%s", genpd->name);
@Ulf: You fine with this ?
