On 13/12/2018 15:24, Marc Gonzalez wrote: > I'm having trouble getting UFS working on an APQ8098 MEDIABOX dev board. > (I'm running v4.20-rc4 with a few UFS patches taken off the MSM list.) > > I'm hoping someone with experience with the UFSHC will spot the one thing > missing that will make everything work! Based on Jeffrey's feedback, I looked at voltage regulators again, and I think there might be an issue in drivers/scsi/ufs/ufshcd.c ufshcd_enable_vreg() is supposed to enable a given voltage regulator. To do so it calls ufshcd_config_vreg() and then regulator_enable() ufshcd_config_vreg() calls regulator_set_voltage() and regulator_set_load() However, regulator_set_load() fails if the regulator is not enabled. So ufshcd_enable_vreg() fails because the regulator is not enabled... Catch 22?
