On 11/01/2019 16:03, Jeffrey Hugo wrote:
> On 1/11/2019 7:50 AM, Marc Gonzalez wrote:
>
>> +&ufshc {
>> +/*** vdd-hba-supply = <&gcc UFS_GDSC>; -EPROBE_DEFER ***/
>
> Downstream the GDSCs are also exposed as regulators. It doesn't appear
> that this is the case upstream. I think this should just be removed.
However, the driver might need to be updated?
ufshcd-qcom 1da4000.ufshc: ufshcd_populate_vreg: Unable to find vdd-hba-supply regulator, assuming enabled
drivers/scsi/ufs/ufshcd-pltfrm.c: dev_info(dev, "%s: Unable to find %s regulator, assuming enabled\n",
snprintf(prop_name, MAX_PROP_SIZE, "%s-supply", name);
if (!of_parse_phandle(np, prop_name, 0)) {
dev_info(dev, "%s: Unable to find %s regulator, assuming enabled\n",
__func__, prop_name);
goto out;
}
/**
* ufshcd_parse_regulator_info - get regulator info from device tree
* @hba: per adapter instance
*
* Get regulator info from device tree for vcc, vccq, vccq2 power supplies.
* If any of the supplies are not defined it is assumed that they are always-on
* and hence return zero. If the property is defined but parsing is failed
* then return corresponding error.
*/
static int ufshcd_parse_regulator_info(struct ufs_hba *hba)
{
int err;
struct device *dev = hba->dev;
struct ufs_vreg_info *info = &hba->vreg_info;
err = ufshcd_populate_vreg(dev, "vdd-hba", &info->vdd_hba);
if (err)
goto out;
err = ufshcd_populate_vreg(dev, "vcc", &info->vcc);
if (err)
goto out;
err = ufshcd_populate_vreg(dev, "vccq", &info->vccq);
if (err)
goto out;
err = ufshcd_populate_vreg(dev, "vccq2", &info->vccq2);
out:
return err;
}
