On 06/12/2018 17:58, Bjorn Andersson wrote: > On Tue 20 Nov 13:08 PST 2018, Sibi Sankar wrote: > >> Add power-domain bindings for Q6V5 MSS on SDM845 SoCs. > > Thanks Sibi, > >> Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx> >> --- >> >> Add dt-binding corresponding to https://patchwork.kernel.org/patch/10586893/ >> (remoteproc: q6v5: Add support to vote for rpmh power domains) >> >> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> index 14947562bc67..bd9f4882fcf0 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> @@ -75,6 +75,17 @@ on the Qualcomm Hexagon core. >> Definition: reference to the regulators to be held on behalf of the >> booting of the Hexagon core >> >> +- power-domains: >> + Usage: required >> + Value type: <phandle> >> + Definition: reference to the cx, mx and mss power-domains to be held on >> + behalf of the booting the Hexagon core > > This should mention that these are the domains for SDM845, as the list > seems to differ somewhat between platforms. Please also define the > requirements for MSM8996 (cx & mx) here, while you're at it. Yeah, and let's not forget MSM8998/SDM835, because it wouldn't be fair that only the other SoCs get all the love! ^_^ Regards.