On 03/12/2018 16:47, Jeffrey Hugo wrote:
> On 12/3/2018 8:27 AM, Jeffrey Hugo wrote:
>
>> On 12/3/2018 8:18 AM, Marc Gonzalez wrote:
>>
>>> + ufsphy: phy@1da7000 {
>>> + compatible = "qcom,sdm845-qmp-ufs-phy";
>>> + reg = <0x1da7000 0x18c>;
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges;
>>> + clock-names =
>>> + "ref_clk_src",
>>> + "ref_clk",
>>> + "ref_aux_clk";
>>> + clocks =
>>> + <&rpmcc 0>,
>>> + <&gcc GCC_UFS_CLKREF_CLK>,
>
> Also, "GCC_UFS_CLKREF_CLK" is not defined in
> include/dt-bindings/clock/qcom,gcc-msm8998.h which is probably the cause
> of your -2 error listed above.
If it were undefined, dtc would have kicked me in the nads :-)
$ git grep GCC_UFS_CLKREF_CLK include
include/dt-bindings/clock/qcom,gcc-msm8996.h:#define GCC_UFS_CLKREF_CLK 215
include/dt-bindings/clock/qcom,gcc-msm8998.h:#define GCC_UFS_CLKREF_CLK 168
include/dt-bindings/clock/qcom,gcc-sdm660.h:#define GCC_UFS_CLKREF_CLK 81
Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt spells it out:
For "qcom,sdm845-qmp-ufs-phy", clock-names must contain "ref", "ref_aux".
Regards.
