Re: [PATCH v2 5/6] drivers: qcom: rpmh-rsc: write PDC data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 12, 2018 at 04:33:56PM -0600, Lina Iyer wrote:
> On Wed, Sep 12 2018 at 16:28 -0600, Matthias Kaehlcke wrote:
> > On Fri, Jul 27, 2018 at 03:34:48PM +0530, Raju P L S S S N wrote:
> > > From: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> > > 
> > > The Power Domain Controller can be programmed to wakeup the RSC and
> > > setup the resources back in the active state, before the processor is
> > > woken up by a timer interrupt. The wakeup value from the timer hardware
> > > can be copied to the PDC which has its own timer and is in an always-on
> > > power domain. Programming the wakeup value is done through a separate
> > > register on the RSC.
> > > 
> > > Signed-off-by: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> > > Signed-off-by: Raju P.L.S.S.S.N <rplsssn@xxxxxxxxxxxxxx>
> > > ---
> > > Changes in v2:
> > >    - Remove unnecessary EXPORT_SYMBOL
> > > ---
> > 
> > > +int rpmh_rsc_write_pdc_data(struct rsc_drv *drv, const struct tcs_request *msg)
> > > +{
> > > +	int i;
> > > +	void __iomem *addr = drv->base + RSC_PDC_DRV_DATA;
> > > +
> > > +	if (!msg || !msg->cmds || msg->num_cmds != RSC_PDC_DATA_SIZE)
> > > +		return -EINVAL;
> > 
> > Is it really always exactly 2 (RSC_PDC_DATA_SIZE) commands?
> > 
> Yes, always.

Thanks for the confirmation!

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux