On 31-07-18, 12:54, Vinod wrote:
> On 31-07-18, 00:01, Bjorn Andersson wrote:
> > On Mon 30 Jul 23:32 PDT 2018, Vinod Koul wrote:
> > > + pon@800 {
> > > + compatible = "qcom,pm8916-pon";
> > > +
> > > + reg = <0x800>;
> > > + mode-bootloader = <0x2>;
> > > + mode-recovery = <0x1>;
> > > +
> > > + pwrkey {
> > > + compatible = "qcom,pm8941-pwrkey";
> > > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> > > + debounce = <15625>;
> > > + bias-pull-up;
> > > + linux,code = <KEY_POWER>;
> > > + };
> > > +
> >
> > Didn't think of this in the 8916 patch, but while the reboot reasons and
> > power key is pretty generic the mapping of RESIN to volume down isn't.
> >
> > So while we should specify the pwrkey here in the pmic dtsi, I think we
> > should move the resin to the device dtsi.
>
> I agree with you on that, how does this work wrt DT semantics:
>
> I should do:
yeah this seems to work with a bit of tweak, will send v2 shortly..
>
> pon@800 {
> compatible = "qcom,pm8916-pon";
>
> reg = <0x800>;
> mode-bootloader = <0x2>;
> mode-recovery = <0x1>;
>
> pwrkey {
> compatible = "qcom,pm8941-pwrkey";
> interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> debounce = <15625>;
> bias-pull-up;
> linux,code = <KEY_POWER>;
> };
>
> for soc DT and add below for device DT..
>
> pon@800 {
> resin {
> compatible = "qcom,pm8941-resin";
> interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> debounce = <15625>;
> bias-pull-up;
> linux,code = <KEY_VOLUMEDOWN>;
> };
> };
>
> --
> ~Vinod
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
