On 4/12/2018 4:54 PM, Matthias Kaehlcke wrote:
> On Mon, Apr 09, 2018 at 01:38:37PM -0600, Karthikeyan Ramasubramanian wrote:
>
>> -static struct qcom_geni_serial_port qcom_geni_console_port;
>> +static struct qcom_geni_serial_port qcom_geni_console_port = {
>> + .uport = {
>> + .iotype = UPIO_MEM,
>> + .ops = &qcom_geni_console_pops,
>> + .flags = UPF_BOOT_AUTOCONF,
>> + .line = 0,
>> + },
>> +};
>
> This change itself looks good to me, however I wonder why there is
> a single qcom_geni_serial_port object that is returned by
> get_port_from_line() for any line. Neither the initial commit message
> of the driver not the comments in this file mention a limitation to a
> single port.
>
> Is support for more than one UART planned for future revisions or are
> there hardware/firmware limitations that impede this?
Yes, in addition to console, there are other non-console UART use-cases
planned for future revisions
>
>> static int qcom_geni_serial_request_port(struct uart_port *uport)
Regards,
Karthik.
--
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
