Re: pinctrl: qcom: ipq4019: Use of gpio-hog's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Montag, 26. März 2018 20:39:39 CEST Christian Lamparter wrote:
[...]
> > What is the correct way for qcom,ipq4019-pinctrl to configure a pin during 
> > bootup (gpio-hog)? I can use the deprecated gpio sysfs infrastructure for
> > now but this seems to be only a dirty hack.
> > 
> I found the bug/issue and it's sort of specific to OF, pinctrl and gpio-hog.
> 
> However I do think that all pinctrl drivers are affect that call
> gpiochip_add_pin_range() *after* (devm_)gpiochip_add_data().
[...]
> For ipq4019 (and all the others too?), there is this an workaround
> that can be done:
> 
> Add the gpio-ranges property to the pinctrl node in the qcom-ipq4019.dtsi:
> 
> tlmm: pinctrl@1000000 {
>         gpio-ranges = <&tlmm 0 0 99>;
> };
> 
> and remove the gpiochip_add_pin_range() call in:
> <https://elixir.bootlin.com/linux/v4.16-rc7/source/drivers/pinctrl/qcom/pinctrl-msm.c#L834>
[...]

Thanks a lot for investigating this. I think this be discussed first by the 
maintainers. Also Benoit Parrot should be asked here [1] because he integrated 
the gpio-hog support for gpiolib-of.

Kind regards,
	Sven

[1] https://lkml.kernel.org/r/46130418.GjRpGRXmAF@debian64

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux