On Thu 12 Jan 05:53 PST 2017, Avaneesh Kumar Dwivedi wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 9d1d7ad..2457b20 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -541,5 +541,29 @@ > #interrupt-cells = <2>; > }; > }; > + > + smp2p-slpi { > + compatible = "qcom,smp2p"; > + qcom,smem = <481>, <430>; > + > + interrupts = <0 178 1>; Please use <GIC_SPI 178 IRQ_TYPE_EDGE_RISING>; > + > + qcom,ipc = <&apcs 4 8>; Looking at qcom,smp2p-dsps downstream I get this to <&apcs 16 26>; > + > + qcom,local-pid = <0>; > + qcom,remote-pid = <3>; > + > + slpi_smp2p_in: slave-kernel { > + qcom,entry-name = "slave-kernel"; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; Please correct the indentation of this block. > + > + slpi_smp2p_out: master-kernel { > + qcom,entry-name = "master-kernel"; > + #qcom,state-cells = <1>; > + }; > + }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html