On Wed 14 Dec 07:50 PST 2016, Dwivedi, Avaneesh Kumar (avani) wrote: > > > On 12/14/2016 3:37 AM, Bjorn Andersson wrote: > >On Tue 13 Dec 11:45 PST 2016, Dwivedi, Avaneesh Kumar (avani) wrote: > >>On 12/13/2016 11:39 PM, Bjorn Andersson wrote: > >[..] > >>>Either way, using the non-_relaxed version of writel() will be > >>>equivalent to what you have now. > >>Do you mean if writel is used , udelay() should be removed? > >No, I mean that looping writel_relaxed() + wmb() is roughly > >equivalent to writel(). So with the overall comment of you replacing > >readl_relaxed() and writel_relaxed() with their plain readl/writel > >counterparts takes care of the wmb(). > > Thanks got it, yes my requirement was to get write done before control > reaches udelay(), so i will add readl() before udelay and remove mb() Sounds good. > I hope after this change i can submit next set of patches? Yes, please do. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
