On Sun, Feb 23, 2025 at 07:01:51PM +0800, Pengyu Luo wrote:
> Enabling spi6 caused boot loop on my device(Huawei Matebook E Go),
>
> &spi6 {
> pinctrl-0 = <&spi6_default>;
> pinctrl-names = "default";
>
> status = "okay";
> };
>
> After looking into this, I found the clocks for spi0 to spi7 are
> wrong, we can derive the correct clocks from the regular pattern
> between spi8 to spi15, spi16 to spi23. Or we can verify it according
> to the hex file of BSRC_QSPI.bin(From windows driver qcspi8280.cab)
>
> 000035d0: 0700 4445 5649 4345 0001 000a 005c 5f53 ..DEVICE.....\_S
> 000035e0: 422e 5350 4937 0003 0076 0001 000a 0043 B.SPI7...v.....C
> 000035f0: 4f4d 504f 4e45 4e54 0000 0008 0000 0000 OMPONENT........
> 00003600: 0000 0000 0003 0017 0001 0007 0046 5354 .............FST
> 00003610: 4154 4500 0000 0800 0000 0000 0000 0000 ATE.............
> 00003620: 0300 3d00 0100 1400 4449 5343 4f56 4552 ..=.....DISCOVER
> 00003630: 4142 4c45 5f50 5354 4154 4500 0100 0600 ABLE_PSTATE.....
> 00003640: 434c 4f43 4b00 0100 1700 6763 635f 7175 CLOCK.....gcc_qu
> 00003650: 7076 335f 7772 6170 305f 7336 5f63 6c6b pv3_wrap0_s6_clk
>
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
--
With best wishes
Dmitry
