On Fri, Feb 21, 2025 at 05:52:02PM +0200, Dmitry Baryshkov wrote: > On Qualcomm platforms here are two major kinds of PCIe EP controllers: > ones which use eDMA and IOMMU and the ones which do not (like SDX55 / > SDX65). It doesn't make sense to c&p similar properties all over the > place. Merge these two usecases into a single conditional clause. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 68 +++++++++++----------- > 1 file changed, 35 insertions(+), 33 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index d22022ff2760c5aa84d31e3c719dd4b63adbb4cf..2c1918ca30dcfa8decea684ff6bfe11c602bbc7e 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -131,6 +131,7 @@ required: > > allOf: > - $ref: pci-ep.yaml# > + > - if: > properties: > compatible: > @@ -140,9 +141,43 @@ allOf: > then: > properties: > reg: > + minItems: 6 That's not really necessary - minItems: 6 is in the top level. It doesn't hurt, though. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof