On 21/02/2025 00:10, Dmitry Baryshkov wrote:
+static int cam_cc_x1e80100_configure_plls(struct device *dev, + const struct qcom_cc_desc *desc, + struct regmap *regmap) +{ + int ret; + + ret = devm_pm_runtime_enable(dev); + if (ret) + return ret; + + ret = pm_runtime_resume_and_get(dev); + if (ret) + return ret;I think, it's better to add desc->use_rpm. Then these two calls and pm_runtime_put() can go to a generic code. Or maybe we can enable RPM for all clock controllers?
That second point is pretty interesting - I think at this stage ~ all of them do this boilerplate stuff over and over again ..
--- bod
